Skip to content

Close PRs that try to merge a user's maintenance branch into master #70

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 15, 2017

Conversation

Mariatta
Copy link
Member

@Mariatta Mariatta commented Nov 4, 2017

Close PR that tries to merge the user's maintenance branch into CPython's master.

This will close PR like python/cpython#4266.

Close PR that tries to merge the user's maintenance branch into CPython's master.
@codecov
Copy link

codecov bot commented Nov 4, 2017

Codecov Report

Merging #70 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #70   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          14     14           
  Lines         923    931    +8     
  Branches       55     55           
=====================================
+ Hits          923    931    +8
Impacted Files Coverage Δ
bedevere/close_pr.py 100% <100%> (ø) ⬆️
tests/test_close_pr.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 81f8490...59cbc36. Read the comment docs.

@Mariatta Mariatta requested a review from brettcannon November 10, 2017 03:57
@brettcannon brettcannon changed the title Close invalid PR. Close PRs that try to merge a user's maintenance branch into master Nov 15, 2017
@brettcannon
Copy link
Member

Obviously keep a close eye on this one once you merge to make sure it doesn't over-reach.

@Mariatta Mariatta merged commit ea0f0df into python:master Nov 15, 2017
@Mariatta Mariatta deleted the close-more-invalid-prs branch November 15, 2017 18:12
@Mariatta
Copy link
Member Author

Thanks!

@Mariatta
Copy link
Member Author

Sorry!! I broke things, as seen in python/cpython#4409 🙇‍♀️ Will write another test case and a PR soon.

@brettcannon
Copy link
Member

I had a feeling that regex might be too permissive. 😄 It's okay, I've just gone ahead and rolled back on Heroku to the last version so there's no rush.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants