Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add logging to debug bedevere label staging #594

Merged
merged 2 commits into from
Oct 12, 2023
Merged

Add logging to debug bedevere label staging #594

merged 2 commits into from
Oct 12, 2023

Conversation

Mariatta
Copy link
Member

No description provided.

pradyunsg
pradyunsg reviewed Oct 12, 2023
View reviewed changes
Copy link
Member

@pradyunsg pradyunsg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, although we should make sure we revert this since the debug logs might be contain information that would be suboptimal to be logging.

@Mariatta Mariatta merged commit 72090a4 into python:main Oct 12, 2023
6 checks passed
@Mariatta Mariatta deleted the add-logging branch October 12, 2023 14:57
pradyunsg added a commit to pradyunsg/bedevere that referenced this pull request Oct 12, 2023
@pradyunsg
Revert "Add logging to debug bedevere label staging (python#594)"
986c549 
This reverts commit 72090a4.
pradyunsg added a commit that referenced this pull request Oct 12, 2023
@pradyunsg
Revert "Add logging to debug bedevere label staging (#594)" (#595)
53b2f45 
This reverts commit 72090a4.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pradyunsg pradyunsg pradyunsg left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Mariatta @pradyunsg