Do not fail issue number test for all PRs with skip issue label#487
Merged
ezio-melotti merged 1 commit intopython:mainfrom Oct 10, 2022
DanielNoord:issue
Merged
Do not fail issue number test for all PRs with skip issue label#487ezio-melotti merged 1 commit intopython:mainfrom DanielNoord:issue
skip issue label#487ezio-melotti merged 1 commit intopython:mainfrom
DanielNoord:issue
Conversation
Codecov Report
@@ Coverage Diff @@
## main #487 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 18 18
Lines 1815 1849 +34
Branches 220 224 +4
=========================================
+ Hits 1815 1849 +34
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Member
|
The change in |
ezio-melotti
approved these changes
Oct 10, 2022
Member
|
This seems to work: python/cpython#98163 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #468.
This check should be done before we get any other information.
I had to change some test data because they were "incomplete". I could also check for the label on the old lines 52-54, but then we would unnecessarily validate the issue number we found in the title. Thought it made more sense to do it like this.