Update comment: *almost* every change needs a NEWS entry#447
Merged
Mariatta merged 2 commits intopython:masterfrom May 6, 2022
Merged
Update comment: *almost* every change needs a NEWS entry#447Mariatta merged 2 commits intopython:masterfrom
Mariatta merged 2 commits intopython:masterfrom
Conversation
Member
|
See #439 for more alternative suggestions |
Member
Author
|
Updated following discussion in #439. |
Codecov Report
@@ Coverage Diff @@
## master #447 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 18 18
Lines 1720 1720
Branches 208 208
=========================================
Hits 1720 1720
|
Mariatta
approved these changes
May 6, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bedevere's comment is slightly misleading (for example):
Bedevere's link to the devguide begins:
And then details the exceptions.
Let's update Bedevere's comment to say "Almost every change ..." instead of "Every change ...".