You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Add tests label for changes in test.support helpers #679
changed the title [-]Add `tests` label if a change happened to a `test.support` helper[/-][+]Add `tests` label for changes in `test.support` helpers[/+]on Dec 7, 2025
Most PRs for library/core etc will hopefully include tests. For those, tests are incidental rather than the focus.
If there is a change outside of tests, the loop will return early, and the tests label won't be applied. I'm just extending the heuristic to include matching files that don't start with test_|_test but are still in the test/ directory.
How can we automatically identify PRs for which the primary focus is tests, rather than tests as a part of some other part of the project?
My question was on semantics - if we have a PR that only changes test_pathlib, should that have the tests label or the library label? I'd say the latter is more relevant. How should bedevere make such judgments?
Activity
[-]Add `tests` label if a change happened to a `test.support` helper[/-][+]Add `tests` label for changes in `test.support` helpers[/+]johnslavik commentedon Dec 7, 2025
Maybe a glob for
Lib/test/**.pyon top of the^(test_|_test)heuristics?AA-Turner commentedon Dec 7, 2025
Most PRs for library/core etc will hopefully include tests. For those, tests are incidental rather than the focus.
How can we automatically identify PRs for which the primary focus is tests, rather than tests as a part of some other part of the project?
A
johnslavik commentedon Dec 7, 2025
If there is a change outside of tests, the loop will return early, and the
testslabel won't be applied. I'm just extending the heuristic to include matching files that don't start withtest_|_testbut are still in thetest/directory.This is already handled by the loop.
AA-Turner commentedon Dec 7, 2025
I don't follow. This is an issue, not a PR?
My question was on semantics - if we have a PR that only changes test_pathlib, should that have the tests label or the library label? I'd say the latter is more relevant. How should bedevere make such judgments?
A
johnslavik commentedon Dec 7, 2025
Sorry, I misunderstood. If we constrain this to just
Lib/test/support/**glob (maybe without the.py), that would surely solve the problem. Right?