Skip to content

Shouldn't Sir classify changes in test modules by "tests" label? #605

Closed
@skirpichev

Description

@skirpichev

Now we have only this pattern:

elif filepath.name.startswith("test_"):
tests = True

to trigger "tests" label.

I believe we could add also filepath.name.startswith("_test") alternative to mark so also changes in test modules. PR examples:

It seems to be a safe choice:

$ find . -name '_test*'
./Programs/_testembed.c
./PCbuild/_testconsole.vcxproj.filters
./PCbuild/_testclinic.vcxproj
./PCbuild/_testmultiphase.vcxproj
./PCbuild/_testembed.vcxproj
./PCbuild/_testimportmultiple.vcxproj.filters
./PCbuild/_testconsole.vcxproj
./PCbuild/_testbuffer.vcxproj
./PCbuild/_testsinglephase.vcxproj.filters
./PCbuild/_testmultiphase.vcxproj.filters
./PCbuild/_testimportmultiple.vcxproj
./PCbuild/_testclinic.vcxproj.filters
./PCbuild/_testbuffer.vcxproj.filters
./PCbuild/_testinternalcapi.vcxproj.filters
./PCbuild/_testinternalcapi.vcxproj
./PCbuild/_testsinglephase.vcxproj
./PCbuild/_testembed.vcxproj.filters
./PCbuild/_testclinic_limited.vcxproj.filters
./PCbuild/_testcapi.vcxproj.filters
./PCbuild/_testcapi.vcxproj
./PCbuild/_testclinic_limited.vcxproj
./Lib/test/_test_eintr.py
./Lib/test/_test_venv_multiprocessing.py
./Lib/test/test_unittest/_test_warnings.py
./Lib/test/_test_atexit.py
./Lib/test/test_zipfile/_path/_test_params.py
./Lib/test/_test_multiprocessing.py
./Lib/test/_test_embed_structseq.py
./Lib/test/_test_embed_set_config.py
./Modules/_testcapi
./Modules/_testcapi_feature_macros.inc
./Modules/_testimportmultiple.c
./Modules/_testinternalcapi
./Modules/_testmultiphase.c
./Modules/_testclinic_limited.c
./Modules/_testclinic.c
./Modules/clinic/_testclinic.c.h
./Modules/clinic/_testclinic_depr.c.h
./Modules/clinic/_testinternalcapi.c.h
./Modules/clinic/_testmultiphase.c.h
./Modules/clinic/_testclinic_limited.c.h
./Modules/_testcapimodule.c
./Modules/_testsinglephase.c
./Modules/_testinternalcapi.c
./Modules/_testbuffer.c
./PC/clinic/_testconsole.c.h
./PC/_testconsole.c

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions