Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(testing): add .coveragerc #718

Merged
merged 1 commit into from
Apr 10, 2023
Merged

fix(testing): add .coveragerc #718

merged 1 commit into from
Apr 10, 2023

Conversation

StephenSorriaux
Copy link
Member

Why is this needed?

This fixes the coverage configuration that is wrongly giving a test coverage for the tests and testing folders and ends up "blocking" PR because of codecov.

Proposed Changes

  • add .coveragerc file and exclude tests and testing folder all together

Does this PR introduce any breaking change?

No, only good stuff here.

This fixes the `coverage` configuration that is wrongly giving a test coverage for the `tests` and `testing` folders and ends up "blocking" PR because of `codecov`.
@codecov
Copy link

codecov bot commented Apr 10, 2023

Codecov Report

Patch coverage has no change and project coverage change: +1.50 🎉

Comparison is base (33c348b) 94.78% compared to head (1d692d6) 96.28%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #718      +/-   ##
==========================================
+ Coverage   94.78%   96.28%   +1.50%     
==========================================
  Files          57       27      -30     
  Lines        8339     3554    -4785     
==========================================
- Hits         7904     3422    -4482     
+ Misses        435      132     -303     

see 35 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@jeffwidman jeffwidman merged commit 6dbf606 into master Apr 10, 2023
@jeffwidman jeffwidman deleted the fix/coverage branch April 10, 2023 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants