Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(core): Introduce black code formatter #673

Merged
merged 5 commits into from
Oct 17, 2022

Conversation

ceache
Copy link
Contributor

@ceache ceache commented Oct 15, 2022

Use black to format the code

Why is this needed?

Remove friction during development caused by styling differences.
Minimize diffs.

Proposed Changes

  • Format all code with black
  • Add a style check to the gh action

Does this PR introduce any breaking change?

No

docs/conf.py Show resolved Hide resolved
docs/conf.py Show resolved Hide resolved
docs/conf.py Show resolved Hide resolved
kazoo/client.py Show resolved Hide resolved
kazoo/handlers/utils.py Show resolved Hide resolved
kazoo/protocol/serialization.py Show resolved Hide resolved
kazoo/protocol/serialization.py Show resolved Hide resolved
kazoo/protocol/serialization.py Show resolved Hide resolved
kazoo/protocol/serialization.py Show resolved Hide resolved
kazoo/protocol/serialization.py Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented Oct 15, 2022

Codecov Report

Base: 94.39% // Head: 94.40% // Increases project coverage by +0.01% 🎉

Coverage data is based on head (644eeb7) compared to base (cb2fe85).
Patch coverage: 89.36% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #673      +/-   ##
==========================================
+ Coverage   94.39%   94.40%   +0.01%     
==========================================
  Files          57       57              
  Lines        8399     8399              
==========================================
+ Hits         7928     7929       +1     
+ Misses        471      470       -1     
Impacted Files Coverage Δ
kazoo/python2atexit.py 40.62% <0.00%> (ø)
kazoo/recipe/election.py 100.00% <ø> (ø)
kazoo/tests/conftest.py 42.85% <0.00%> (ø)
kazoo/tests/test_eventlet_handler.py 88.52% <0.00%> (-1.64%) ⬇️
kazoo/tests/test_gevent_handler.py 80.28% <0.00%> (ø)
kazoo/tests/test_cache.py 57.48% <26.38%> (ø)
kazoo/tests/test_election.py 91.30% <50.00%> (ø)
kazoo/tests/test_build.py 87.50% <66.66%> (ø)
kazoo/testing/common.py 78.78% <72.41%> (ø)
kazoo/tests/util.py 62.50% <75.00%> (-1.39%) ⬇️
... and 57 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

kazoo/tests/util.py Outdated Show resolved Hide resolved
kazoo/tests/util.py Outdated Show resolved Hide resolved
@ceache ceache marked this pull request as draft October 16, 2022 05:10
@ceache ceache force-pushed the chore/black branch 3 times, most recently from fade0f4 to 5f3b801 Compare October 16, 2022 14:09
@ceache ceache marked this pull request as ready for review October 16, 2022 14:43
@ceache ceache changed the title Chore/black chore(core): Introduce black code formatter Oct 16, 2022
@ceache
Copy link
Contributor Author

ceache commented Oct 17, 2022

@StephenSorriaux rebased and ready for review

Copy link
Member

@StephenSorriaux StephenSorriaux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@ceache ceache merged commit a192b2e into python-zk:master Oct 17, 2022
@ceache ceache deleted the chore/black branch October 17, 2022 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants