Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: migrate to setup.cfg #666

Merged
merged 1 commit into from
Sep 30, 2022
Merged

Conversation

ceache
Copy link
Contributor

@ceache ceache commented May 14, 2022

closes #644 #662 #663

Why is this needed?

Migrate to python packaging best practices.

Proposed Changes

  • use setup.cfg & pyproject.toml to build kazoo

Does this PR introduce any breaking change?

No

@codecov-commenter
Copy link

codecov-commenter commented May 14, 2022

Codecov Report

Merging #666 (9ed34ce) into master (9bb8499) will decrease coverage by 0.01%.
The diff coverage is 50.00%.

@@            Coverage Diff             @@
##           master     #666      +/-   ##
==========================================
- Coverage   94.47%   94.45%   -0.02%     
==========================================
  Files          57       57              
  Lines        8375     8368       -7     
==========================================
- Hits         7912     7904       -8     
- Misses        463      464       +1     
Impacted Files Coverage Δ
kazoo/tests/test_selectors_select.py 95.00% <50.00%> (-2.02%) ⬇️
kazoo/recipe/barrier.py 97.93% <0.00%> (-1.04%) ⬇️
kazoo/protocol/connection.py 95.05% <0.00%> (ø)
kazoo/tests/test_client.py 98.80% <0.00%> (+0.09%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9bb8499...9ed34ce. Read the comment docs.

@ceache ceache marked this pull request as ready for review June 2, 2022 20:18
@StephenSorriaux
Copy link
Member

Hey @ceache

Really sorry for not having check this before :(

Copy link
Member

@StephenSorriaux StephenSorriaux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Programming Language :: Python
Programming Language :: Python :: 3
Programming Language :: Python :: 3.7
Programming Language :: Python :: 3.8
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is Python 3.9 missing?

@ceache
Copy link
Contributor Author

ceache commented Sep 20, 2022 via email

@StephenSorriaux StephenSorriaux merged commit 5f7ae48 into python-zk:master Sep 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Need bump pure-sasl version to support winkerberos
3 participants