feat(recipe): add support for curator SharedCount recipe #559
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this patch allows java clients using curator's SharedCount recipe
and python clients using kazoo's Counter recipe to read and
write from the same path without receiving type errors.
example use:
counter = zk.Counter("/curator", support_curator_shared_count=True)
counter += 2
counter -= 1
counter.value == 1
counter.pre_value == 2
counter.post_value == 1
Closes python-zk#558
houndci-bot
reviewed
May 2, 2019
kazoo/tests/test_counter.py
Outdated
| self.assertRaises(TypeError, counter.__add__, 2.1) | ||
| self.assertRaises(TypeError, counter.__add__, b"a") | ||
| with self.assertRaises(TypeError): | ||
| counter = self._makeOne(default=0.0, support_curator_shared_count=True) |
kazoo/tests/test_counter.py
Outdated
| counter - 1 | ||
| eq_(counter.value, -1) | ||
| counter += 1 | ||
| counter += 2147483647 |
kazoo/recipe/counter.py
Outdated
| self.pre_value = None | ||
| self.post_value = None | ||
| if self.support_curator_shared_count and not isinstance(self.default, int): | ||
| raise TypeError('when support_curator_shared_count is enabled the default type must be an int') |
There was a problem hiding this comment.
line too long (107 > 79 characters)
kazoo/recipe/counter.py
Outdated
| self._ensured_path = False | ||
| self.pre_value = None | ||
| self.post_value = None | ||
| if self.support_curator_shared_count and not isinstance(self.default, int): |
kazoo/recipe/counter.py
Outdated
| :param path: The counter path to use. | ||
| :param default: The default value. | ||
| :param default: The default value to use for new counter paths. | ||
| :param support_curator_shared_count: Enable if support for curator's SharedCount recipe is desired. |
There was a problem hiding this comment.
line too long (107 > 79 characters)
kazoo/recipe/counter.py
Outdated
| either kazoo's counter recipe or curator's SharedCount recipe, you will | ||
| need to enable the support_curator_shared_count flag. This flag limits | ||
| support to integers only and does not use ascii encoding as described | ||
| above. |
kazoo/recipe/counter.py
Outdated
| If you would like to support clients updating the same znode path using | ||
| either kazoo's counter recipe or curator's SharedCount recipe, you will | ||
| need to enable the support_curator_shared_count flag. This flag limits | ||
| support to integers only and does not use ascii encoding as described |
kazoo/recipe/counter.py
Outdated
| If you would like to support clients updating the same znode path using | ||
| either kazoo's counter recipe or curator's SharedCount recipe, you will | ||
| need to enable the support_curator_shared_count flag. This flag limits |
kazoo/recipe/counter.py
Outdated
| such other data types might be used for the counter value. | ||
| If you would like to support clients updating the same znode path using | ||
| either kazoo's counter recipe or curator's SharedCount recipe, you will |
kazoo/recipe/counter.py
Outdated
| `type(counter.default)(value)` both using an ascii encoding. As | ||
| such other data types might be used for the counter value. | ||
| If you would like to support clients updating the same znode path using |
houndci-bot
reviewed
May 2, 2019
kazoo/recipe/counter.py
Outdated
| :param path: The counter path to use. | ||
| :param default: The default value. | ||
| :param default: The default value to use for new counter paths. | ||
| :param support_curator: Enable if support for curator's SharedCount |
|
Hi @BrianEaton1, Thanks a lot for your time to produce this PR. I will review it as soon as possible. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this patch allows java clients using curator's SharedCount recipe
and python clients using kazoo's Counter recipe to read and
write from the same path without receiving type errors.
example use:
counter = zk.Counter("/curator", support_curator=True)counter += 2counter -= 1counter.value == 1counter.pre_value == 2counter.post_value == 1Closes #558