fix(core): Use a copy of auth data when reconnecting #509
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arushiagg
changed the title
|
One of the tests seems to have had a connection loss error. Does not seem related to the change. Is there a way i can rerun the tests? |
jeffwidman
requested changes
Sep 25, 2018
There was a problem hiding this comment.
The problem description / solution seems reasonable... happy to merge a fix.
Our changelog generator script requires commit messages to be formatted like this: https://github.com/python-zk/kazoo/blob/master/CONTRIBUTING.md#git-commit-guidelines
Can you rebase and update the commit message accordingly?
arushiagg
force-pushed
the
master
branch
2 times, most recently
from
c2b0433 to
aef041b
Compare
It is possible to race between processing a new addAuth request(which updates the client.auth_data set) and iterating through it during reconnect. To avoid set changes during iteration, make a copy.
|
Rebased, and updated to fix commit message/typo. |
arushiagg
changed the title
jeffwidman
approved these changes
Oct 6, 2018
There was a problem hiding this comment.
Looks good, I fixed the merge conflict caused by merging #512 before this. Waiting for tests to pass so that I can merge it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is possible to race between processing a new addAuth request(which updates the client.auth_data set) and iterating through it during reconnect. To avoid set changes during iteration, make a copy.