Fix the client.add_auth hangs by xids mismatch. #400
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tonyseek
force-pushed
the
hotfix/xid-mismatch
branch
from
3241da2
to
62c6917
Compare
This commit fixes python-zk#229 by throwing the runtime exception into the dequeued async_result. It will end the waiting of user threading. But this commit doesn't fix the xids mismatch itself. The unordered xids may caused by a bug from the ZooKeeper server side, such as the official issues https://issues.apache.org/jira/browse/ZOOKEEPER-1863 described.
tonyseek
force-pushed
the
hotfix/xid-mismatch
branch
from
62c6917
to
61a3576
Compare
|
@bbangert Could you review this patch? CC @wooparadog |
|
Looks good, nice test too! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes #229 by throwing the runtime exception into the dequeued
async_result. It will end the waiting of user threading.But this commit doesn't fix the xids mismatch itself (#254). The unordered xids may caused by a bug from the ZooKeeper server side, such as the official issues ZOOKEEPER-1863 described.