Close the ChildrenWatch if the node doesn't exist. #393
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tonyseek
force-pushed
the
hotfix/handle-children-watch-nonode
branch
5 times, most recently
from
dd8cbc4
to
baec5f9
Compare
This implementation resolves the "NoNodeError" while watching children. Fix python-zk#149.
tonyseek
force-pushed
the
hotfix/handle-children-watch-nonode
branch
from
baec5f9
to
6fd5062
Compare
tonyseek
changed the title
|
@bbangert Could you review this patch? |
|
|
||
| # delete watching | ||
| self.client.delete(path) | ||
| time.sleep(1) |
There was a problem hiding this comment.
It'd be nice if there was a non-timing dependent way to wait for this. But I understand there may not be. Maybe if the test tries to grab the watchers _run_lock which should be released as soon as _stopped is set and returned?
There was a problem hiding this comment.
It is a good idea. I will have a try.
|
LGTM |
tonyseek
force-pushed
the
hotfix/handle-children-watch-nonode
branch
2 times, most recently
from
141b90b
to
b742888
Compare
tonyseek
force-pushed
the
hotfix/handle-children-watch-nonode
branch
from
b742888
to
2016924
Compare
tonyseek
added a commit
to eleme/kazoo
that referenced
this pull request
Sep 27, 2016
Backport python-zk#393 into eleme-2.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implementation resolves the "NoNodeError" while watching children.
Fix #149.