Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kazoo patch to workaround select's file descriptor limitation #171

Closed
pattyshack opened this issue Feb 27, 2014 · 1 comment · Fixed by #448
Closed

kazoo patch to workaround select's file descriptor limitation #171

pattyshack opened this issue Feb 27, 2014 · 1 comment · Fixed by #448
Labels
Enhancement

Comments

@pattyshack
Copy link

I wrote a patch to deal with the fact that select cannot handle file descriptors larger than 1024 (This problem is common to most posix select implementations). I would like to upstream this change.

This patch is only applicable to posix based systems (Windows does not support epoll).

patch: https://www.dropbox.com/s/9dae2bfk1jfilwr/kazoo-1.3.1.patch

original thread: https://groups.google.com/forum/#!topic/python-zk/kzX_8BBBpCM
@bbangert
Copy link
Member

bbangert commented Jun 1, 2017

If this can be done as a PR and merged cleanly I'd be happy to include it. Closing this otherwise, feel free to re-open along with a PR using the latest master if you'd like to address it.

@bbangert bbangert closed this as completed Jun 1, 2017
packysauce added a commit to packysauce/kazoo that referenced this issue Jun 2, 2017
@packysauce
Use epoll when available to support fds > 1023
a98c9f3 
This would use select() at all times, except on systems that have epoll,
it would use epoll if we *know* select is going to fail (ie, fd > 1023)

closes python-zk#266
closes python-zk#171
packysauce added a commit to packysauce/kazoo that referenced this issue Jun 2, 2017
@packysauce
Use epoll when available to support fds > 1023
5b693a2 
This would use select() at all times, except on systems that have epoll,
it would use epoll if we *know* select is going to fail (ie, fd > 1023)

closes python-zk#266
closes python-zk#171
@packysauce packysauce mentioned this issue Jun 2, 2017
Merged
packysauce added a commit to packysauce/kazoo that referenced this issue Jun 3, 2017
@packysauce
Use epoll when available to support fds > 1023
1156e61 
This would use select() at all times, except on systems that have epoll,
it would use epoll if we *know* select is going to fail (ie, fd > 1023)

closes python-zk#266
closes python-zk#171
packysauce added a commit to packysauce/kazoo that referenced this issue Jun 4, 2017
@packysauce
Use epoll when available to support fds > 1023
321d7c5 
This would use select() at all times, except on systems that have epoll,
it would use epoll if we *know* select is going to fail (ie, fd > 1023)

closes python-zk#266
closes python-zk#171
packysauce added a commit to packysauce/kazoo that referenced this issue Jun 4, 2017
@packysauce
feat(core): use epoll when available to support fds > 1023
267e61b 
When epoll is available, and the highest fd in use is > 1023, route through epoll.
Otherwise, use the existing select() behavior so by and large nothing changes.

Closes python-zk#266, python-zk#171
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use epoll when available to support fds > 1023 packysauce/kazoo
2 participants
@bbangert @pattyshack