Fix shell completion on FreeBSD #79
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sed on FreeBSD does not support '\s', and gives the error: "sed: 1: "/^\s*$/d": RE error: trailing backslash (\)" Fix by using POSIX bracket expression '[[:space:]]'
|
I'm not sure why the unit test actions haven't run for this PR. I'm investigating whether I can trigger them myself. |
|
I rebased and created a new PR (#86) and that one is running the jobs. If those pass, it will merge automatically, so I'll close this PR. You will still receive credit for the contribution in the release notes. Thank you for your contribution! |
This was referenced Dec 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sed on FreeBSD does not support '\s', and gives the error: "sed: 1: "/^\s*$/d": RE error: trailing backslash ()"
Fix by using POSIX bracket expression '[[:space:]]'
Fixes #65