Skip to content

Fix issues for python 3.12 #68

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 19, 2023

Conversation

parona-source
Copy link
Contributor

@parona-source parona-source commented Jun 19, 2023

Main things are the final removal of distutils and no setuptools by default in a venv.

Removed all of find_package_data because I didn't see its use, I could've removed just the distutils bits from it and it would've worked the same.

There should be consideration for the removal legacy develop install support and tests. https://setuptools.pypa.io/en/latest/userguide/development_mode.html#legacy-behavior

Also used pip install instead python setup.py because its discouraged by setuptools, it allows me to opt out of using pip install -r requirements.txt and it allows PEP517 build systems to be added to the test packages at a later time without extra changes.

Tested for python3.8, python3.9, python3.10, python3.11 and python3.12 on Gentoo Linux.

* Python 3.11 deprecated distutils and Python 3.12 completely removed it
* Removed find_package_data entirely as there was not package data to
  install

Signed-off-by: Alfred Wingate <parona@protonmail.com>
* setuptools isn't included in ensurepip in Python 3.12
* Use pip install instead of invoking setup.py directly, due to
  setuptools discouraging it and allowing updates for the tests packages
  to use PEP517 compliant build system to done seamlessly. Also don't
  need to invoke pip install -r requirements.txt.
* editable_mode=compat is comparable to python setup.py develop. But
  setuptools doesn't guarantee the longevity of the feature. Removal of
  support for the legacy method would be a thing consider.

Signed-off-by: Alfred Wingate <parona@protonmail.com>
Copy link
Contributor

@dhellmann dhellmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice cleanup work, thank you!

@mergify mergify bot merged commit 23a8c65 into python-virtualenvwrapper:main Jun 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI changes to tox or GitHub action config
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants