Changed workon's env switching to use OR not $?

[Nealium]

Calling type deactivate by itself and using it's exit status breaks if caller is watching for any non-zero exit status.

In my case, a GitLab CI pipeline with a runner calling mkvirtualenv as a Shell command.

Example pipeline output:

Executing "step_script" stage of the job script 00:01
$ . ~/.bashrc
$ mkvirtualenv -r requirements.txt "${ENV_ROOT}_${CI_COMMIT_BRANCH}"
created virtual environment CPython3.10.5.final.0-64 in 338ms
  creator CPython3Posix(dest=/home/gitlab-runner/.virtualenvs/project_a_master, clear=False, no_vcs_ignore=False, global=False)
  seeder FromAppData(download=False, pip=bundle, setuptools=bundle, wheel=bundle, via=copy, app_data_dir=/home/gitlab-runner/.local/share/virtualenv)
    added seed packages: pip==23.0.1, setuptools==67.6.1, wheel==0.40.0
  activators BashActivator,CShellActivator,FishActivator,NushellActivator,PowerShellActivator,PythonActivator
ERROR: Job failed: exit status 1

---

Tested change on:

• Rocky 9, bash (Gitlab-Runner)
• Pop! OS, bash & zsh

[dhellmann]

Does this { start a sub shell?

[Nealium]

Sorry for the delay, sidetracked, was this determined to be in a subshell?

I'm finding the whole topic of determining if it is/isn't confusing and unclear.
$BASH_SUBSHELL seems to indicate it is not. It's not in parentheses and it's not a pipe, so I don't see any reason why it would be

Do subshells potentially raise a bunch of potential problems?- I'm just curious, tidbits and all.

edit: grammar

[dhellmann]

If it's a sub shell, then actions in the braces don't affect the current shell. Running and then unsetting deactivate won't actually do anything.

https://www.gnu.org/software/bash/manual/html_node/Command-Grouping.html#Command-Grouping seems to indicate that {} does not create a new subshell.

[Nealium]

Oh okay! I thought it may have been a compatibility issue, some niche situation or even just bad practice.

I've been daily driving this change, so I know it at least fundamentally works (at least in my env)

[dhellmann]

It looks like the test suite is happy, too.

Thanks for this!