Get coverage to 100% #61
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #61 +/- ##
===========================================
+ Coverage 97.63% 100.00% +2.36%
===========================================
Files 2 2
Lines 127 127
Branches 31 31
===========================================
+ Hits 124 127 +3
+ Misses 1 0 -1
+ Partials 2 0 -2
|
This is needed to get to 100% coverage.
pquentin
changed the title
sethmlarson
approved these changes
May 2, 2020
tests/test_unasync.py
Outdated
|
|
||
|
|
||
| def test_makedirs(monkeypatch): | ||
| import errno |
There was a problem hiding this comment.
Move import to the top of file
tests/test_unasync.py
Outdated
| @@ -136,3 +138,15 @@ def test_project_structure_after_customized_build_py_packages(tmpdir): | |||
|
|
|||
| with open(os.path.join(unasynced_dir_path, "tests/test_conn.py")) as f: | |||
| assert "import hip\n" in f.read() | |||
|
|
|||
|
|
|||
| def test_makedirs(monkeypatch): | |||
There was a problem hiding this comment.
test_makedirs_existok to match function under test
RatanShreshtha
approved these changes
May 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In my experience, 100% coverage is worth it, as it's easy to see when a pull request reduces it.