Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add two more notes-to-self files #538

Merged
merged 1 commit into from
May 21, 2018

Conversation

njsmith
Copy link
Member

@njsmith njsmith commented May 21, 2018

blocking-read-hack.py: This demonstrates a really weird approach to
solving gh-174. See:
#174 (comment)

ntp-example.py: A fully-worked example of using UDP from Trio,
inspired by
#472 (comment)
This should move into the tutorial eventually.

blocking-read-hack.py: This demonstrates a really weird approach to
solving python-triogh-174. See:
  python-trio#174 (comment)

ntp-example.py: A fully-worked example of using UDP from Trio,
inspired by
  python-trio#472 (comment)
This should move into the tutorial eventually.
@codecov
Copy link

codecov bot commented May 21, 2018

Codecov Report

Merging #538 into master will increase coverage by 0.78%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #538      +/-   ##
==========================================
+ Coverage    98.5%   99.28%   +0.78%     
==========================================
  Files          89       89              
  Lines       10483    10483              
  Branches      727      727              
==========================================
+ Hits        10326    10408      +82     
+ Misses        139       58      -81     
+ Partials       18       17       -1
Impacted Files Coverage Δ
trio/_core/_run.py 100% <0%> (+0.48%) ⬆️
trio/tests/test_highlevel_socket.py 100% <0%> (+0.64%) ⬆️
trio/tests/test_socket.py 100% <0%> (+0.76%) ⬆️
trio/_socket.py 100% <0%> (+1.21%) ⬆️
trio/_highlevel_socket.py 100% <0%> (+1.75%) ⬆️
trio/_core/tests/test_result.py 100% <0%> (+2.4%) ⬆️
trio/_util.py 100% <0%> (+6.09%) ⬆️
trio/_core/_io_kqueue.py 78.48% <0%> (+78.48%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 39f9f74...21729b8. Read the comment docs.

@njsmith njsmith merged commit 7eef7d0 into python-trio:master May 21, 2018
@njsmith njsmith deleted the more-notes-to-self branch May 21, 2018 01:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant