Skip to content

Conversation

@A5rocks
Copy link
Contributor

@A5rocks A5rocks commented May 12, 2025

Turns out parsing C takes time! Relevant charts (from before this):

image

image

(x axis is import time in microseconds, excluding anything that module itself imports)

I know there's conflicts but I'll wait until CI is fixed anyways.

@codecov
Copy link

codecov bot commented May 12, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00000%. Comparing base (8771618) to head (33ed865).
⚠️ Report is 53 commits behind head on main.

Additional details and impacted files
@@               Coverage Diff               @@
##                 main        #3263   +/-   ##
===============================================
  Coverage   100.00000%   100.00000%           
===============================================
  Files             127          127           
  Lines           19270        19266    -4     
  Branches         1300         1301    +1     
===============================================
- Hits            19270        19266    -4     
Files with missing lines Coverage Δ
src/trio/_core/_io_windows.py 100.00000% <ø> (ø)
src/trio/_core/_tests/test_windows.py 100.00000% <100.00000%> (ø)
src/trio/_core/_windows_cffi.py 100.00000% <100.00000%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jakkdl
Copy link
Member

jakkdl commented May 12, 2025

maybe add typing-only hints to avoid breaking typing for end users?

@A5rocks
Copy link
Contributor Author

A5rocks commented May 13, 2025

This shouldn't break any typing for end users because it's unexported, but also the reason there's type ignores is because typeshed's stubs are wrong.

@A5rocks
Copy link
Contributor Author

A5rocks commented May 15, 2025

I don't quite get why mypy is failing in CI since I can't repro that locally. Maybe I need to make my environment more similar?

@jakkdl
Copy link
Member

jakkdl commented May 16, 2025

I don't quite get why mypy is failing in CI since I can't repro that locally. Maybe I need to make my environment more similar?

have you tried tox -e typing? (I repro the error when I do)

@A5rocks
Copy link
Contributor Author

A5rocks commented May 17, 2025

Turns out that's the difference between an editable and non-editable install! Scary.

@jakkdl
Copy link
Member

jakkdl commented May 19, 2025

ah, yeah editable installs can confuse static analysis. I remember having a lot of problems with pyright --verifytypes caused by it

Copy link
Member

@jakkdl jakkdl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good as far as I can tell, feel free to merge when ready imo.

@A5rocks A5rocks merged commit ea03051 into python-trio:main Jun 10, 2025
43 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants