-
-
Notifications
You must be signed in to change notification settings - Fork 378
Use CFFI's out-of-line mode for import time reductions on Windows #3263
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3263 +/- ##
===============================================
Coverage 100.00000% 100.00000%
===============================================
Files 127 127
Lines 19270 19266 -4
Branches 1300 1301 +1
===============================================
- Hits 19270 19266 -4
🚀 New features to boost your workflow:
|
|
maybe add typing-only hints to avoid breaking typing for end users? |
|
This shouldn't break any typing for end users because it's unexported, but also the reason there's type ignores is because typeshed's stubs are wrong. |
|
I don't quite get why mypy is failing in CI since I can't repro that locally. Maybe I need to make my environment more similar? |
have you tried |
|
Turns out that's the difference between an editable and non-editable install! Scary. |
|
ah, yeah editable installs can confuse static analysis. I remember having a lot of problems with |
jakkdl
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good as far as I can tell, feel free to merge when ready imo.
Turns out parsing C takes time! Relevant charts (from before this):
(x axis is import time in microseconds, excluding anything that module itself imports)
I know there's conflicts but I'll wait until CI is fixed anyways.