Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix static analysis tests on 3.12 #2656

Merged
merged 2 commits into from
Jun 1, 2023

Conversation

jakkdl
Copy link
Member

@jakkdl jakkdl commented May 31, 2023

See #2646, fixes all of the errors in test_exports.py

Opened python/mypy#15330, didn't seem like there was a tracking issue for ast being deprecated.

Did ~zero research on why jedi is missing additional dunders, so somebody might want to check that out and/or open an issue upstream.

@codecov
Copy link

codecov bot commented May 31, 2023

Codecov Report

Merging #2656 (31894ec) into master (8ae599c) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2656   +/-   ##
=======================================
  Coverage   98.14%   98.14%           
=======================================
  Files         118      118           
  Lines       16466    16473    +7     
  Branches     2974     2977    +3     
=======================================
+ Hits        16161    16168    +7     
  Misses        249      249           
  Partials       56       56           
Impacted Files Coverage Δ
trio/socket.py 100.00% <ø> (ø)
trio/_path.py 100.00% <100.00%> (ø)
trio/_tests/test_exports.py 99.34% <100.00%> (+0.03%) ⬆️

@A5rocks
Copy link
Contributor

A5rocks commented May 31, 2023

Codecov seems like it's being skipped on 3.12 cause the pytest step is failing. We should put an if: always() or something on it.

@jakkdl
Copy link
Member Author

jakkdl commented Jun 1, 2023

Nice!

Future problem to figure out / prevent the timeouts

@jakkdl jakkdl merged commit b2e617a into python-trio:master Jun 1, 2023
@jakkdl jakkdl deleted the py312_static_analysis branch June 1, 2023 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants