Bump up the timeout in test_pipes to hopefully reduce spurious CI failures #1715
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1715 +/- ##
=======================================
Coverage 99.61% 99.61%
=======================================
Files 115 115
Lines 14445 14445
Branches 1106 1106
=======================================
Hits 14389 14389
Misses 41 41
Partials 15 15
|
altendky
approved these changes
Sep 5, 2020
There was a problem hiding this comment.
Over in QTrio I had plenty of timeouts on subprocessed pytest tests including ones that did nearly nothing. It seemed they would cluster a bit so there would be a few successful builds and then one job would fail three or four such subprocessed tests. Bad luck getting slow workers? Overloaded? Bumping timeouts from 10 to 40 seconds seemed to end the flakiness so 30 sounds reasonable to me.
|
Yeah, I think these free CI systems are overprovisioned and have really noisy neighbors, so sometimes your whole VM will just like, freeze for a few seconds and then resume. So you need pretty generous timeouts. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.