-
-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix asyncio.get_running_loop() monkey-patching (#83) #99
Conversation
Looks good. Please add |
955cb1f
to
aa6549a
Compare
News fragment added 👍 |
Codecov Report
@@ Coverage Diff @@
## master #99 +/- ##
==========================================
- Coverage 80.61% 80.48% -0.14%
==========================================
Files 11 11
Lines 1238 1240 +2
Branches 172 172
==========================================
Hits 998 998
- Misses 170 171 +1
- Partials 70 71 +1
|
I've tried rerunning the checks a few times, but at least one macOS test hangs due to GitHub Actions bug. Every time a different macOS hangs. For this reason I can't merge this PR :( @oremanj could you please mark all macOS tests as non-required? |
@@ -0,0 +1,2 @@ | |||
:func:`asyncio.get_running_loop()` will now return the trio-asyncio event loop |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe :func:
wants its referent to be specified without the trailing parens. This made me realize we aren't testing newsfragments as part of the docs build. I created #102 to fix.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Never mind, it appears to work either way!
Hey @niklasf, it looks like that was the first time we merged one of your PRs! Thanks so much! 🎉 🎂 If you want to keep contributing, we'd love to have you. So, I just sent you an invitation to join the python-trio organization on Github! If you accept, then here's what will happen:
If you want to read more, here's the relevant section in our contributing guide. Alternatively, you're free to decline or ignore the invitation. You'll still be able to contribute as much or as little as you like, and I won't hassle you about joining again. But if you ever change your mind, just let us know and we'll send another invitation. We'd love to have you, but more importantly we want you to do whatever's best for you. If you have any questions, well... I am just a humble Python script, so I probably can't help. But please do post a comment here, or in our chat, or on our forum, whatever's easiest, and someone will help you out! |
Since Python 3.7
asyncio.get_running_loop()
is public, so we will have to monkey-patch that in addition to the already monkey-patched internalasyncio.events.get_running_loop()
.Part of #83.