Skip to content

Conversation

@RazerM
Copy link
Member

@RazerM RazerM commented Jul 5, 2018

Fixes #17

@codecov
Copy link

codecov bot commented Jul 5, 2018

Codecov Report

Merging #18 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #18   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           8      8           
  Lines         226    229    +3     
  Branches       12     12           
=====================================
+ Hits          226    229    +3
Impacted Files Coverage Δ
tests/test_sync.py 100% <100%> (ø) ⬆️
src/outcome/_async.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4ec1933...733667d. Read the comment docs.

@njsmith
Copy link
Member

njsmith commented Jul 5, 2018

Huh, I hadn't seen the hoops you were jumping through to support Python 2 here before. That's clever! Though complex enough that it makes me wonder whether supporting Python 2 is worth it :-).

Anyway, this fix looks good to me!

@njsmith njsmith merged commit fd13d87 into python-trio:master Jul 5, 2018
@RazerM RazerM deleted the fix-inheritance branch July 5, 2018 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants