async102 & async120 no longer requires cancelscope to have a timeout#380
Merged
jakkdl merged 5 commits intopython-trio:mainfrom May 7, 2025
Merged
async102 & async120 no longer requires cancelscope to have a timeout#380jakkdl merged 5 commits intopython-trio:mainfrom
jakkdl merged 5 commits intopython-trio:mainfrom
Conversation
Zac-HD
approved these changes
May 6, 2025
Member
Zac-HD
left a comment
Zac-HD
left a comment
There was a problem hiding this comment.
LGTM once the linter is happy 🙂
docs/changelog.rst
Outdated
|
|
||
| 25.5.2 | ||
| ====== | ||
| - :ref:`ASYNC120 <async120>` no longer requires cancel scopes to have a timeout. https://github.com/python-trio/flake8-async/issues/272 |
Member
There was a problem hiding this comment.
Let's give the url some link text, e.g. (issue #272)
jakkdl
changed the title
Member
Author
|
|
Member
Author
|
prettified all urls in the changelog, and also noticed that one of them was pointing at the entirely wrong issue (may have been copypasted from previous entry) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #272