add async400 exceptiongroup-invalid-access#379
Merged
jakkdl merged 3 commits intopython-trio:mainfrom May 7, 2025
Merged
Conversation
Member
Author
|
hm, in hindsight I maybe should've used |
Zac-HD
approved these changes
May 6, 2025
Member
Zac-HD
left a comment
Zac-HD
left a comment
There was a problem hiding this comment.
one more test as below, then let's go!
Comment on lines
17
to
28
| EXCGROUP_ATTRS = ( | ||
| # from ExceptionGroup | ||
| "message", | ||
| "exceptions", | ||
| "subgroup", | ||
| "split", | ||
| "derive", | ||
| # from BaseException | ||
| "args", | ||
| "with_traceback", | ||
| "add_notes", | ||
| ) |
Member
There was a problem hiding this comment.
Let's add a test that set(dir(ExceptionGroup)).issubset(EXCGROUP_ATTRS), so that if a new method or attribute is added (e.g. by PEP-785 😅) we'll notice as soon as we test on that version of Python, rather than when users complain.
Member
Author
There was a problem hiding this comment.
oopie, that caught a typo. Turns out it's add_note and not add_notes ^^;
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pretty straightforward, bulk of it is in avoiding false alarms