code cleanup after 91x PR

[jakkdl]

Fix comments from #143 and general minor code cleanup

[jakkdl]

Actually, since I landed on ast.literal_eval being pretty much the same as matching against an integer + handling unary operation, I rewrote iter_guaranteed_once_cst not to need cst_literal_eval. It probably wouldn't be very hard at all to evaluate unary/binary ops either, and range(10*23) isn't that uncommon. Can open an issue for it

And with the only remaining user of it being visit_While_test ... and I don't think we care about handling while [1, 2]: ... (and can get it for free if libcst implements evaluated_value for containers), I rewrote that one as well .. and completely removed cst_literal_eval.

[Zac-HD]

Minor nitpicks but great overall, go ahead and merge once you've addressed to your satisfaction 😁

[Zac-HD]

I think this | syntax requires Python 3.10?

[jakkdl]

I think it's fine due to from __future__ import annotations?
But regardless, tests run with <3.10, and I don't think we care about whether pyright running on 3.9 passes.

[Zac-HD]

🤦 it's fine at runtime because we're in an if TYPE_CHECKING: block and so it never actually runs, nevermind.

[jakkdl]

haha I didn't realize that either, https://github.com/snok/flake8-type-checking doing it's job!

[Zac-HD]

Missing the ~ operator! https://docs.python.org/3/reference/expressions.html#unary-arithmetic-and-bitwise-operations

[jakkdl]

Good catch! Although I suspect it's quite rare to invert bits in range loops 😅

[Zac-HD]

I certainly hope so! At large enough scale though, someone is bound to...

[jakkdl]

And of course this checker is gonna reach that scale 😁

[jakkdl]

Reading through https://docs.python.org/3/library/stdtypes.html#range it mentioned len not working with sys.maxsize - so code now handles very long loops now as well 😃

    # length > sys.maxsize
    for i in range(27670116110564327421):
        await foo()
    yield

[Zac-HD]

Reading through https://docs.python.org/3/library/stdtypes.html#range it mentioned len not working with sys.maxsize

Heh, that note is my fault 😂 (Hypothesis is a great way to find edge cases...)

[jakkdl]

ooh, nice!