Skip to content

Adapt to trio norms + add @asynccontextmanager + add sphinx docs #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 15 commits into from
Jan 19, 2018

Conversation

njsmith
Copy link
Member

@njsmith njsmith commented Jan 19, 2018

No description provided.

@codecov
Copy link

codecov bot commented Jan 19, 2018

Codecov Report

Merging #9 into master will increase coverage by 8.12%.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master     #9      +/-   ##
========================================
+ Coverage   91.87%   100%   +8.12%     
========================================
  Files           5      7       +2     
  Lines         591    776     +185     
  Branches       48     59      +11     
========================================
+ Hits          543    776     +233     
+ Misses         48      0      -48
Impacted Files Coverage Δ
async_generator/_impl.py 100% <ø> (ø)
async_generator/_util.py 100% <100%> (ø)
async_generator/_tests/test_util.py 100% <100%> (ø)
async_generator/__init__.py 100% <100%> (+100%) ⬆️
async_generator/_tests/test_async_generator.py 100% <100%> (ø)
async_generator/_tests/conftest.py 100% <100%> (ø)
async_generator/_version.py 100% <100%> (ø)
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 339fc63...a1974c6. Read the comment docs.

@njsmith
Copy link
Member Author

njsmith commented Jan 19, 2018

I cannot figure out why the coverage here is so messed up. We're using exactly the same scripts as trio. Yet for some reason it looks like the coverage gathering is only getting turned on after we import the module, so all the lines that are executed on import show up as being not-covered.

@njsmith
Copy link
Member Author

njsmith commented Jan 19, 2018

AHHHH hahaha I figured it out.

We use pytest-asyncio as a convenient way to run async functions.

pytest-asyncio at some point... started using this library! So if pytest happens to load the pytest-asyncio plugin before it loads the pytest-cov plugin, then we get imported then too.

Also it's kind of bad if our testing infrastructure indirectly depends on the code-under-test, we should probably fix that anyway.

@njsmith njsmith merged commit d9ca342 into python-trio:master Jan 19, 2018
@njsmith njsmith deleted the trioify branch January 19, 2018 12:48

.. image:: https://img.shields.io/badge/docs-read%20now-blue.svg
:target: https://async-generator.readthedocs.io/en/latest/?badge=latest
:alt: Documentation Status

.. image:: https://travis-ci.org/njsmith/async_generator.svg?branch=master
:target: https://travis-ci.org/njsmith/async_generator
:alt: Automated test status
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that this image and the codecov one below link to njsmith/async_generator.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoops, good catch. Want to fix it? :-)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, #10 :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants