-
-
Notifications
You must be signed in to change notification settings - Fork 26
Adapt to trio norms + add @asynccontextmanager + add sphinx docs #9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
All commits in history are mine except for two trivial ones from Alex Gronholm. Also, the old license was already MIT, so adding Apache 2 is compatible anyway.
Codecov Report
@@ Coverage Diff @@
## master #9 +/- ##
========================================
+ Coverage 91.87% 100% +8.12%
========================================
Files 5 7 +2
Lines 591 776 +185
Branches 48 59 +11
========================================
+ Hits 543 776 +233
+ Misses 48 0 -48
Continue to review full report at Codecov.
|
I cannot figure out why the coverage here is so messed up. We're using exactly the same scripts as trio. Yet for some reason it looks like the coverage gathering is only getting turned on after we import the module, so all the lines that are executed on import show up as being not-covered. |
AHHHH hahaha I figured it out. We use
Also it's kind of bad if our testing infrastructure indirectly depends on the code-under-test, we should probably fix that anyway. |
|
||
.. image:: https://img.shields.io/badge/docs-read%20now-blue.svg | ||
:target: https://async-generator.readthedocs.io/en/latest/?badge=latest | ||
:alt: Documentation Status | ||
|
||
.. image:: https://travis-ci.org/njsmith/async_generator.svg?branch=master | ||
:target: https://travis-ci.org/njsmith/async_generator | ||
:alt: Automated test status |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note that this image and the codecov one below link to njsmith/async_generator.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Whoops, good catch. Want to fix it? :-)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, #10 :)
No description provided.