Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct syntax highlighting in README #18

Closed
wants to merge 2 commits into from

Conversation

touilleMan
Copy link
Member

It seems Github no longer recognizes python3 in rst's code-block:: xxx tags.
Beside Github's python highlighting seems to accept Python3 keywords like await/async.

@codecov
Copy link

codecov bot commented Apr 13, 2018

Codecov Report

Merging #18 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #18   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           7      7           
  Lines         776    776           
  Branches       59     59           
=====================================
  Hits          776    776

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 17521f8...541f92b. Read the comment docs.

@touilleMan
Copy link
Member Author

(btw I just realized doing this edit from the Github website made me create a branch in the main repo instead of forking and working on my own... sorry for that 😢 )

@njsmith
Copy link
Member

njsmith commented Apr 13, 2018

See #12 – Github never recognized python3, but pypi requires it. Github merged my patch to start accepting python3 like 2 months ago, but I guess they must still not have deployed it...? idk

@touilleMan
Copy link
Member Author

but pypi requires it

Do you know if it requires it on the old pypi website, the new one or on both ?

Anyway, feel free to close this PR (and remove the related branch). I can do it myself if you prefer

@njsmith
Copy link
Member

njsmith commented Aug 1, 2018

.. code-block:: python3 seems to be working on Github now!

@njsmith njsmith closed this Aug 1, 2018
@njsmith njsmith deleted the correct-syntax-highlighting branch August 1, 2018 03:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants