Skip to content

Fix: Static typechecking behaving weirdly #75

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 17, 2024

Conversation

caffeine-addictt
Copy link
Member

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Optimization
  • Breaking Change
  • Documentation Update

Description

Static typechecking types _get_value as a function which expects the arguments SupportsXXX and int and not a protocol-compatible type.

Related Tickets & Documents

  • Related Issue #
  • Closes #

QA Instructions, Screenshots, Recordings

Please replace this line with instructions on how to test your changes, a note
on the devices and browsers this has been tested on, as well as any relevant
images for UI changes.

Added/updated tests?

We encourage you to keep the code coverage percentage at 80% and above.

  • Yes
  • No, and this is why: Not affected
  • I need help with writing tests

[optional] Are there any post deployment tasks we need to perform?

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have incremented the version according to semantic versioning.
  • I have updated the changelog accordingly.

@caffeine-addictt caffeine-addictt added the Type: Bug Something isn't working as expected. label Mar 17, 2024
@caffeine-addictt caffeine-addictt self-assigned this Mar 17, 2024
@github-actions github-actions bot added Documentation An issue/change with the documentation. Scope: Core labels Mar 17, 2024
@caffeine-addictt caffeine-addictt merged commit 8f1ad08 into main Mar 17, 2024
@caffeine-addictt caffeine-addictt deleted the fix/typechecking-error-for-valid branch March 17, 2024 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation An issue/change with the documentation. Type: Bug Something isn't working as expected.
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant