Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handle models that use "email" as username_field #157

Merged
merged 1 commit into from
Oct 28, 2018
Merged

handle models that use "email" as username_field #157

merged 1 commit into from
Oct 28, 2018

Conversation

imposeren
Copy link
Contributor

If model have not 'usrername' field because User.USERNAME_FIELD is "email" then user creation fails. This PR should fix that issue

@imposeren
Copy link
Contributor Author

imposeren commented Jun 4, 2018

Should fix #158

@codecov-io
Copy link

codecov-io commented Jun 4, 2018

Codecov Report

Merging #157 into master will decrease coverage by 0.06%.
The diff coverage is 75%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #157      +/-   ##
==========================================
- Coverage   92.03%   91.96%   -0.07%     
==========================================
  Files          35       35              
  Lines        1256     1270      +14     
==========================================
+ Hits         1156     1168      +12     
- Misses        100      102       +2
Impacted Files Coverage Δ
social_django/storage.py 98.46% <75%> (-1.54%) ⬇️
social_django/management/__init__.py 58.92% <0%> (+2.05%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 751b572...5c29df6. Read the comment docs.

@omab omab merged commit f4faf8b into python-social-auth:master Oct 28, 2018
@omab
Copy link
Contributor

omab commented Oct 28, 2018

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants