fix: use resolve() instead of absolute() in verify_git_repo_dir#1444
Merged
codejedi365 merged 7 commits intoJul 6, 2026
Merged
Conversation
aconal-com
force-pushed
the
fix/monorepo-repo-dir-warning
branch
2 times, most recently
from
b1868fd to
bf5fdff
Compare
codejedi365
force-pushed
the
fix/monorepo-repo-dir-warning
branch
2 times, most recently
from
46fe586 to
a35990c
Compare
codejedi365
force-pushed
the
fix/monorepo-repo-dir-warning
branch
from
a35990c to
f169563
Compare
codejedi365
force-pushed
the
fix/monorepo-repo-dir-warning
branch
2 times, most recently
from
aab052c to
8813112
Compare
…epos configured with `..`
In monorepo setups where repo_dir='..' is configured for a subpackage,
Path('..').absolute() returns /path/to/package/.. rather than the resolved
/path/to/repo. This change resolves symlinks and normalizes paths, preventing
false 'Found .git/ in higher parent directory' warnings.
Resolves: python-semantic-release#1418
Co-authored-by: Aniket Karne <aniketkarne@gmail.com>
Co-authored-by: codejedi365 <codejedi365@users.noreply.github.com>
Signed-off-by: codejedi365 <codejedi365@users.noreply.github.com>
codejedi365
force-pushed
the
fix/monorepo-repo-dir-warning
branch
from
8813112 to
6b61018
Compare
codejedi365
merged commit 7a1f822
into
python-semantic-release:master
31 of 36 checks passed
Contributor
|
@aconal-com, Thank you for the contribution. A few tips for contributing:
|
Contributor
🎉 This PR has been published as part of v10.6.1 🎉You can find more information about this release on the GitHub Releases page. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In monorepo setups where
repo_dir='..'is configured for a subpackage,Path('..').absolute()returns/path/to/package/..rather than the resolved/path/to/repo. Usingresolve()properly handles symlinks and normalizes paths, preventing false 'Found .git/ in higher parent directory' warnings.Fixes #1418