Skip to content

Add default implementation for is_dir() - #870

Merged
lieryan merged 1 commit into
masterfrom
lieryan-implement-resource-is-dir
Sep 4, 2026
Merged

lieryan merged 1 commit into
masterfrom
lieryan-implement-resource-is-dir

Conversation

@lieryan

@lieryan lieryan commented Sep 4, 2026 •

Copy link
Copy Markdown
Member

Description

is_dir() is the name used by os.PathLike interface, while is_folder() was the original name used by rope's Resource.

At some point, Resource became an implementor of os.PathLike but it never provided an implementation for is_dir().

Checklist (delete if not relevant):

  • I have added tests that prove my fix is effective or that my feature works
  • I have updated CHANGELOG.md

is_dir() is the name used by os.PathLike interface, while is_folder()
was the original name used by rope's Resource.

At some point, Resource became an implementor of os.PathLike but it
never provided an implementation for is_dir().
@lieryan
lieryan force-pushed the lieryan-implement-resource-is-dir branch from 944ca89 to 392f729 Compare September 4, 2026 14:34
@lieryan lieryan added this to the 1.15.0 milestone Sep 4, 2026
@lieryan
lieryan enabled auto-merge September 4, 2026 14:35
@codecov

codecov Bot commented Sep 4, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.29%. Comparing base (d2c5127) to head (392f729).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #870   +/-   ##
=======================================
  Coverage   95.28%   95.29%           
=======================================
  Files         134      134           
  Lines       26534    26541    +7     
=======================================
+ Hits        25284    25291    +7     
  Misses       1250     1250           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@lieryan
lieryan merged commit f005ac7 into master Sep 4, 2026
45 checks passed
@lieryan
lieryan deleted the lieryan-implement-resource-is-dir branch September 4, 2026 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant