Fix renaming kwargs when refactoring from imports#646
Merged
lieryan merged 2 commits intopython-rope:masterfrom Jan 11, 2023
Merged
Fix renaming kwargs when refactoring from imports#646lieryan merged 2 commits intopython-rope:masterfrom
lieryan merged 2 commits intopython-rope:masterfrom
Conversation
2aabd21 to
ff4f5db
Compare
Member
|
The fix looks reasonable, thanks @apmorton! @all-contributors add @apmorton for code contribution |
Contributor
|
I've put up a pull request to add @apmorton! 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When converting from imports on a large codebase I encountered many files that failed with errors of the form:
This was traced back to erroneously renaming keyword arguments that conflicted with renamed imports, resulting in code that looked something like the following:
Before
After