-
Notifications
You must be signed in to change notification settings - Fork 343
Fix Issue #164: generate choices schema without collectionFormat #165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## master #165 +/- ##
==========================================
- Coverage 96.92% 96.92% -0.01%
==========================================
Files 19 19
Lines 2696 2695 -1
==========================================
- Hits 2613 2612 -1
Misses 83 83
Continue to review full report at Codecov.
|
|
i have no idea what coverage wants from me |
|
By removing a line of code, you've technically reduced the coverage percentage, so annoyingly, to make this pass you'd need to add a test that adds a new line of coverage, or make some code take more lines than it used to 😅 |
|
Do we have to do codecov's bidding in obvious cases like this? Adding lines of code just to please a tool is insane. |
|
I agree with you, but I'm not associated with this project, sorry! |
|
Hello, No problem for the "coverage failure". What are you trying to solve? This is explained in our CONTRIBUTING guidelines. |
|
@ziirish the commits reference a bug originally raised in flask restplus: |
|
Oh yes, my bad. I overlooked the commit messages. |
No description provided.