This repository was archived by the owner on Dec 27, 2021. It is now read-only.
PostgresSQLRole for Centos #87
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Moved common behavior among distributions of PostgreSQLRole to a new base class. To make possible code reuse by other distributions Signed-off-by: Fernando Rocha <fernandogrd@yahoo.com.br>
Signed-off-by: Fernando Rocha <fernandogrd@yahoo.com.br>
Thanks @diogobaeder for the feedback Signed-off-by: Fernando Rocha <fernandogrd@yahoo.com.br>
Signed-off-by: Fernando Rocha <fernandogrd@yahoo.com.br>
Signed-off-by: Fernando Rocha <fernandogrd@yahoo.com.br>
| ''' | ||
| Roles in this namespace are base roles which contain common behavior among | ||
| distribuitions. | ||
| Since them are base classes, they are not suited for provisioning, instead, |
There was a problem hiding this comment.
"Since they are [...]"
Signed-off-by: Fernando Rocha <fernandogrd@yahoo.com.br>
Signed-off-by: Fernando Rocha <fernandogrd@yahoo.com.br>
diogobaeder
added a commit
that referenced
this pull request
Jan 19, 2013
PostgresSQLRole for Centos
|
Thanks a lot for the help and feedback Diogo! |
|
No problem, man! I hope you keep bringing more great news to the project! :-) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For this. I created a base class to put common behavior between Debian and Centos.
Once this is considered a good pattern, it could be use to reduce code duplication in provy codebase.