Skip to content
This repository was archived by the owner on Dec 27, 2021. It is now read-only.

some fix for windows #75

Closed
wants to merge 1 commit into from
Closed

some fix for windows #75

wants to merge 1 commit into from

Conversation

scilo7
Copy link

@scilo7 scilo7 commented Dec 13, 2012

Replace path.join by '/'.join in the debian subfolder, since it is guaranteed to be linux paths. Otherwise, it doesn't work on windows (issues with antislash and backslash).

@diogobaeder
Copy link
Contributor

Hi, @lvasseur !

Thanks for the time to bring Windows support; But the thing is, some of the areas you changed are not covered by tests, and we're striving to have the highest coverage we can - right now I'm not happy with the overall coverage we have, which is about 57%, and the supervisor module is one of the least covered ones, with 27%.

So may I ask you a favor? Can you build some tests to make sure that your changes don't break the current version? These are some hints for you to make it happen:

  • Take a look at the "test" target of the Makefile, that's what we use to run our tests - both in the dev machines and in the Continuous Integration system (travis);
  • Take a look at how the "tests/unit/" directory is organized, and how the unit tests are being structured. They might contain precious clues to how you can build yours in a non-painful way.

Let us know how that goes, and don't hesitate to reach us if you need a hand with that, OK?! :-)

Cheers!

@diogobaeder
Copy link
Contributor

Or, as an alternative, you can wait for me to raise up that coverage, and do your changes. I've been investing some time on overall code coverage, so it would be fine for me to focus on supervisor coverage for this pull request.

@diogobaeder
Copy link
Contributor

So, @lvasseur , I discussed this pull request with @heynemann , and unfortunately the committers of this project don't have easy access to a Windows machine (all of us work either on Linux or MacOSX), which makes it pretty hard to maintain our codebase compatible with Windows. That being said, we opted by not supporting it at all, in order to avoid hindering the progress of this project. We have many features to implement, yet, to get it to a world-class provisioning software, and supporting Windows would not be a wise decision for us, at least not now.

I hope you understand this, and please let us know if you have interest in adopting another *nix-based operating system and in keeping participating to this project. Therefore, I'm closing this issue and won't merge this pull request, sorry for that.

@scilo7
Copy link
Author

scilo7 commented Dec 17, 2012

Hello. Well, I understand the rationale, but it's too bad since it really works on a windows box with the small fix above... Anyway, thanks for the reply, I'll keep an eye on the project.

@diogobaeder
Copy link
Contributor

Thanks for understanging, @lvasseur . Please reach us should you have any further questions or contributions, or need any help! :-)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants