Repository navigation
Conversation
Signed-off-by: Tim Paine <3105306+timkpaine@users.noreply.github.com>
Signed-off-by: Tim Paine <3105306+timkpaine@users.noreply.github.com>
timkpaine
changed the title
Signed-off-by: Tim Paine <3105306+timkpaine@users.noreply.github.com>
timkpaine
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enabling
check-typesmade Copier update python-project-templates/python-template-rustjswasm#149 fail:tycannot resolve the compiled Rust module imported whenadd_pyodide=true. Add anExampleconstructor stub to both Rust templates.Base CI currently renders these templates with Pyodide disabled, so their Python tests never import the compiled module. Add a type check of Pyodide-enabled renders to both existing Rust template jobs. Render the committed SHA to avoid Copier cloning dirty CI fixtures and racing Git maintenance during cleanup.
Verified fresh renders of both templates with Pyodide enabled and disabled. Removing either stub reproduces
unresolved-import. For both enabled renders, Python lint,make checks, Python runtime tests, native wheel builds, and source distribution builds passed on macOS with Python 3.11. Wheels contain the extension and stub; source distributions contain the stub and exclude compiled binaries. Rust/JS/WASM native checks usedSKIP_HATCH_JS=1; the existing CI jobs retain full template tests.Run template type checks with
python -m ty checkand let ty discover the Python environment. Verified both Rust templates with Pyodide enabled and disabled using this command.After this merges, rerun Copier updates to regenerate the affected downstream PRs.