feat: drop support for Python 3.8 - #9692
Merged
Merged
Conversation
finswimmer
force-pushed
the
drop-python38
branch
from
September 17, 2024 04:20
70d335b to
85ceabc
Compare
Contributor
|
From if self._shutdown:
# Cancelling further tasks from being executed
[task.cancel() for task in tasks]
self._executor.shutdown(wait=True)=> if self._shutdown:
self._executor.shutdown(wait=True, cancel_futures=True) |
finswimmer
marked this pull request as ready for review
September 23, 2024 19:09
finswimmer
force-pushed
the
drop-python38
branch
2 times, most recently
from
September 23, 2024 20:13
b8189a1 to
0963d48
Compare
finswimmer
force-pushed
the
drop-python38
branch
2 times, most recently
from
October 5, 2024 15:44
9807b17 to
2d5bd65
Compare
finswimmer
force-pushed
the
drop-python38
branch
3 times, most recently
from
October 12, 2024 14:52
ca34402 to
3a1627c
Compare
finswimmer
force-pushed
the
drop-python38
branch
from
October 18, 2024 13:26
3a1627c to
f008575
Compare
Co-authored-by: Sven van Ashbrook <thesven73@googlemail.com>
radoering
approved these changes
Oct 20, 2024
radoering
enabled auto-merge (squash)
October 20, 2024 10:49
Secrus
pushed a commit
to Secrus/poetry
that referenced
this pull request
Oct 27, 2024
Co-authored-by: Randy Döring <30527984+radoering@users.noreply.github.com> Co-authored-by: Sven van Ashbrook <thesven73@googlemail.com>
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Python 3.8 will be EOL on October. Let's drop the support than for running Poetry itself with it.