-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add docs and schema for multiple readme files support #4743
Add docs and schema for multiple readme files support #4743
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This doc change is relatively meaningless without the core changes to go with it -- by that, I mean that even after your changes are merged into core, they will not be reflected.
Between alpha releases, poetry master
normally tracks poetry-core. I would suggest waiting until your PR lands in core, and then updating pyproject.toml
to reflect the Git dependency so that your changes can be used.
8c075cd
to
f22529d
Compare
@neersighted, please remember to also merge this, given core changes at python-poetry/poetry-core#248 is merged 😊 |
I'm aware! I'm not sure of merging this yet because of two things -- the schema in this repo is actually useless, so I'm thinking we merge a PR to drop it and drop that change from this PR. Additionally, the docs in |
@neersighted did anything change in the meantime or is it still undecided? |
We've had a core release since then, so we should be good to just drop the schema in this PR, and update the docs to reflect the current reality. |
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
poetry-schema.json
to match core's versionPull Request Check List
Related to #873