Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add docs and schema for multiple readme files support #4743

Conversation

wagnerluis1982
Copy link
Contributor

@wagnerluis1982 wagnerluis1982 commented Nov 13, 2021

Pull Request Check List

Related to #873

  • Added tests for changed code.
  • Updated documentation for changed code.

Copy link
Member

@neersighted neersighted left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doc change is relatively meaningless without the core changes to go with it -- by that, I mean that even after your changes are merged into core, they will not be reflected.

Between alpha releases, poetry master normally tracks poetry-core. I would suggest waiting until your PR lands in core, and then updating pyproject.toml to reflect the Git dependency so that your changes can be used.

@neersighted neersighted added status/waiting-on-core Requires changes to poetry-core first area/docs Documentation issues/improvements labels Nov 14, 2021
@wagnerluis1982 wagnerluis1982 marked this pull request as draft November 16, 2021 22:57
@wagnerluis1982 wagnerluis1982 marked this pull request as ready for review November 19, 2021 00:44
@wagnerluis1982 wagnerluis1982 changed the title Add docs for multiple readme files support Add docs and schema for multiple readme files support Nov 19, 2021
@wagnerluis1982
Copy link
Contributor Author

@neersighted, please remember to also merge this, given core changes at python-poetry/poetry-core#248 is merged 😊

@neersighted
Copy link
Member

I'm aware! I'm not sure of merging this yet because of two things -- the schema in this repo is actually useless, so I'm thinking we merge a PR to drop it and drop that change from this PR.

Additionally, the docs in master will be out of sync with the poetry-core dep -- still debating whether we add a git dep or just wait to merge this until after a poetry-core release. I'm not an expert there so I'll have to pick some other brains.

@Secrus
Copy link
Member

Secrus commented May 17, 2022

@neersighted did anything change in the meantime or is it still undecided?

@neersighted
Copy link
Member

@neersighted did anything change in the meantime or is it still undecided?

We've had a core release since then, so we should be good to just drop the schema in this PR, and update the docs to reflect the current reality.

@neersighted
Copy link
Member

This has been superseded by #5678 and #5158. Thank you for your contribution!

@neersighted neersighted closed this Jun 4, 2022
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area/docs Documentation issues/improvements status/waiting-on-core Requires changes to poetry-core first
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants