Conversation
poetry run / env.execute copy the host environment for children of a virtualenv-backed env, stripping PYTHONHOME but not PYTHONPATH, so a host PYTHONPATH leaks into the isolated interpreter (same defect as pdm-project/pdm#3742). The venv should resolve packages itself.
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
poetry runandenv.executeon a virtualenv-backed environment copy the host environment for the child process.get_temp_environstripsPYTHONHOMEand__PYVENV_LAUNCHER__, but notPYTHONPATH, so aPYTHONPATHexported in the host shell leaks into the isolated interpreter:A venv is expected to resolve packages itself, and the same leak was treated as a bug in pdm (pdm-project/pdm#3742). Strip
PYTHONPATHalongside the otherPYTHON*vars.Adds a regression test that runs a real script in a tmp venv with
PYTHONPATHset in the host env; fails on main.