fix: resolve Windows command wrappers before execution - #10999
Draft
Rishav23av wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Check List
Resolves: #10482
What changed
On Windows, Poetry now resolves
.cmdwrappers in a virtual environment before handing the command to the shell. Existing.exelookup keeps its current priority, and explicit.cmdarguments are handled too.The existing editable-dependency command test now uses a PATH longer than the reported
cmd.exelimit. Unit tests cover.exeprecedence,.cmdfallback, and explicit suffixes.Checks
pytest tests/utils/env/test_env.py tests/console/commands/test_run.py -p no:randomly— 58 passed, 1 Windows-only test skipped locallymypyon the three changed filesruff check --ignore FURB188andruff format --checkon the three changed filesgit diff --checkThe long-PATH end-to-end assertion is Windows-only and will be exercised by CI. The implementation and review were assisted by Claude Code and Codex; I reviewed the final diff and test results.