Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Poetry doesn't correctly normalise the package name for the wheel data section #7117

Closed
4 tasks done
robtaylor opened this issue Nov 28, 2022 · 6 comments · Fixed by python-poetry/poetry-core#532
Closed
4 tasks done
Labels
area/build-system Related to PEP 517 packaging (see poetry-core) kind/bug Something isn't working as expected

Comments

@robtaylor
Copy link

robtaylor commented Nov 28, 2022

  • I am on the latest stable Poetry version, installed using a recommended method.
  • I have searched the issues of this repo and believe that this is not a duplicate.
  • I have consulted the FAQ and blog for any relevant entries or release notes.
  • If an exception occurs when executing a command, I executed it again in debug mode (-vvv option) and have included the output below.

Issue

When building a wheel, the name of the data section should be {distribution}-{version}.data, where {distribution} is the PEP 503 normalisation followed by replacing - with _.

See Binary distribution format

Currently the data section is using _package.name rather than distribution_version(_package.name) (https://github.com/python-poetry/poetry-core/blob/d98aa6e49f614f7631667da3144d7b291c7e7889/src/poetry/core/masonry/builders/wheel.py#L310)

@robtaylor robtaylor added kind/bug Something isn't working as expected status/triage This issue needs to be triaged labels Nov 28, 2022
@neersighted
Copy link
Member

Please provide the versions you have tested with, as well as examples of the incorrect output, what you expect the correct output to be, and what commands/tools can be used to reproduce.

This sounds like a chore, but will get your issue looked at in a more timely fashion and ensure that those who try to help you/reproduce it can do so quickly and consistently.

@robtaylor
Copy link
Author

sorry, i'm not sure how to do the request for this issue. Do you want me to attach a wheel showing the issue? any poetry built wheel will do...

@neersighted
Copy link
Member

A pyproject.toml along with a sequence of commands you are using to build wheels, and then examples of the resulting filenames, plus what you would consider to be the correct filenames, would illustrate your issue and make it unambiguous what is wrong.

@dimbleby
Copy link
Contributor

It would probably have been worth mentioning that you've already provided a pull request including unit test changes...

python-poetry/poetry-core#532

@robtaylor
Copy link
Author

robtaylor commented Dec 14, 2022 via email

@radoering radoering added area/build-system Related to PEP 517 packaging (see poetry-core) and removed status/triage This issue needs to be triaged labels Dec 19, 2022
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area/build-system Related to PEP 517 packaging (see poetry-core) kind/bug Something isn't working as expected
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants