fix: subprocess doesn't allow Path on windows, 3.7 (#7932)

python-poetry · May 16, 2023 · 73bc4eb · 73bc4eb
1 parent 3f2469a
commit 73bc4eb
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 4 deletions.
diff --git a/src/poetry/utils/env.py b/src/poetry/utils/env.py
@@ -544,7 +544,7 @@ def get_python_version(
             if executable:
                 python_patch = decode(
                     subprocess.check_output(
-                        [executable, "-c", GET_PYTHON_VERSION_ONELINER],
+                        [str(executable), "-c", GET_PYTHON_VERSION_ONELINER],
                     ).strip()
                 )
 
@@ -579,7 +579,7 @@ def activate(self, python: str) -> Env:
         try:
             python_version_string = decode(
                 subprocess.check_output(
-                    [python_path, "-c", GET_PYTHON_VERSION_ONELINER],
+                    [str(python_path), "-c", GET_PYTHON_VERSION_ONELINER],
                 )
             )
         except CalledProcessError as e:
@@ -906,7 +906,7 @@ def create_venv(
         if executable:
             python_patch = decode(
                 subprocess.check_output(
-                    [executable, "-c", GET_PYTHON_VERSION_ONELINER],
+                    [str(executable), "-c", GET_PYTHON_VERSION_ONELINER],
                 ).strip()
             )
             python_minor = ".".join(python_patch.split(".")[:2])
@@ -954,7 +954,7 @@ def create_venv(
                 try:
                     python_patch = decode(
                         subprocess.check_output(
-                            [python, "-c", GET_PYTHON_VERSION_ONELINER],
+                            [str(python), "-c", GET_PYTHON_VERSION_ONELINER],
                             stderr=subprocess.STDOUT,
                         ).strip()
                     )

diff --git a/tests/utils/test_env.py b/tests/utils/test_env.py
@@ -192,6 +192,7 @@ def check_output_wrapper(
 ) -> Callable[[list[str], Any, Any], str]:
     def check_output(cmd: list[str], *args: Any, **kwargs: Any) -> str:
         # cmd is a list, like ["python", "-c", "do stuff"]
+        assert all(isinstance(arg, str) for arg in cmd)
         python_cmd = cmd[2]
         if "sys.version_info[:3]" in python_cmd:
             return version.text