Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix stub-only partial namespace packages not recognized as packages #221

Conversation

henribru
Copy link
Contributor

@henribru henribru commented Oct 14, 2021

Resolves: python-poetry/poetry#4621

  • Added tests for changed code.
  • N/A Updated documentation for changed code.

The tests are based on the existing tests for stub-only packages introduced in python-poetry/poetry#2000

@finswimmer finswimmer requested a review from a team December 28, 2021 07:29
neersighted
neersighted previously approved these changes Jan 25, 2022
@dimbleby dimbleby mentioned this pull request Feb 9, 2022
@abn
Copy link
Member

abn commented May 5, 2022

@henribru can you rebase this please?

@henribru
Copy link
Contributor Author

henribru commented May 6, 2022

Done!

@henribru henribru changed the title Fix stub-only partial namespace packages not recognized as packages Fix stub-only namespace packages not recognized as packages May 6, 2022
@henribru henribru changed the title Fix stub-only namespace packages not recognized as packages Fix stub-only partial namespace packages not recognized as packages May 6, 2022
@sonarcloud
Copy link

sonarcloud bot commented May 6, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@neersighted neersighted merged commit a435116 into python-poetry:master May 7, 2022
@finswimmer finswimmer mentioned this pull request May 20, 2022
julienmalard added a commit to julienmalard/poetry-core that referenced this pull request Aug 22, 2022
This fixes python-poetry#221 by exchanging the regex package for re (the former having fixed the long-standing bug in re (see [here](lark-parser/lark#590) for details). Not sure if this will work for poetry (i.e., whether adding regex as a dependency is acceptable)...but thought I would propose this change and wait for feedback to take it from there.
Thanks!
bostonrwalker pushed a commit to bostonrwalker/poetry-core that referenced this pull request Aug 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Namespace stub-only packages can't be built with Poetry
4 participants