Merged
Conversation
Secrus
force-pushed
the
remove-crashtest
branch
2 times, most recently
from
bef5ac1 to
ae2ef78
Compare
trag1c
requested changes
Nov 7, 2023
Member
trag1c
left a comment
trag1c
left a comment
There was a problem hiding this comment.
Not sure how strongly you feel about this but I'd personally change cls.__name__ to type(cls), makes the dunder chaos a bit more bearable :v
Secrus
force-pushed
the
remove-crashtest
branch
2 times, most recently
from
53d613b to
cc69aa8
Compare
Secrus
force-pushed
the
remove-crashtest
branch
from
cc69aa8 to
9742cfa
Compare
branchv
reviewed
Nov 16, 2023
trag1c
approved these changes
Nov 16, 2023
Secrus
force-pushed
the
remove-crashtest
branch
from
9742cfa to
0948c7a
Compare
Secrus
force-pushed
the
remove-crashtest
branch
from
0948c7a to
f12a0c5
Compare
branchv
approved these changes
Nov 16, 2023
dimbleby
reviewed
Nov 18, 2023
| return self._file_content | ||
|
|
||
| def __hash__(self) -> int: | ||
| return reduce(operator.xor, map(hash, self._key)) |
Contributor
There was a problem hiding this comment.
simply return hash(self._key) was what I had intended, apologies if not clear
this in general is a better hash eg hash((1, 2)) is not the same as hash((2, 1)); and also it is just simpler
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
crashtestintroduced a burden of additional dependency, that wasn't maintained. This PR moves some Exception inspection logic fromcrashtestintocleoand removescrashtestas a dependency.