Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Isolate macOS wheel builds from Homebrew #8497
Isolate macOS wheel builds from Homebrew #8497
Changes from 1 commit
0fe55d6
fc35fcc
00809a2
06dbfed
5a8373e
140a06e
0961d3d
43c34fc
3e4be4b
0855468
8308bf3
c74a5bd
72d81e2
ec214e4
d1a4f80
6d13704
467f120
c6912f8
96ae15c
01270b5
51e3623
e82b539
904416b
4e35852
681a03b
378df7a
9dc6904
0e3eb70
54f2334
96b898c
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would have thought just '/usr/local', based on https://docs.brew.sh/Installation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Turns out both work (for
brew
at least) - Homebrew keeps the "original" versions in /usr/local/homebrew. However, I agree that/usr/local
is the generally intended entry point.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I take that back - it does matter (and making this change caused test failures on x86_64).
Firstly, it's possible for homebrew to have packages installed, but not linked. Using the
/usr/local/Homebrew
location ensures that the binary can be used regardless (note also the capitalisation fix - doesn't strictly matter on HFS+, but for accuracy).Secondly, it's possible for other libraries to be in
/usr/local/lib
. Using/usr/local/Homebrew/lib
for theDYLD_LIBRARY_PATH
avoids this.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What was the reason for this change?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Explicitness. Xcode can manage multiple SDKs (iOS being an obvious one); adding the explicit
--sdk macosx
SDK ensures that you're definitely getting the macOS one. That will be the default on almost every install of Xcode, but if you have a straySDKROOT
environment variable from some other activity, it could be inadvertently pointing at an iOS, tvOS, visionOS or MacCatalyst SDK.