Do not convert images unnecessarily in ImageEnhance #8431
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If an attempt is made to convert an image to its current mode (without a matrix), a copy is simply returned.
However,
copy()
still consumes resources, and it would be ideal to avoid it where possible. In ImageEnhance, there are a few such instances.What if the image already matches
self.intermediate_mode
inColor
?Pillow/src/PIL/ImageEnhance.py
Line 58 in c6b08ef
What if the image is already L mode in
Enhance
?Pillow/src/PIL/ImageEnhance.py
Lines 69 to 72 in c6b08ef
This PR skips calling
convert()
for those scenarios.