Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Select Python version in Cygwin #7091

Merged
merged 2 commits into from
Apr 15, 2023

Conversation

radarhere
Copy link
Member

Cygwin started failing in main, with https://github.com/python-pillow/Pillow/actions/runs/4696586061/jobs/8329527067#step:8:157

  gcc -Wno-unused-result -Wsign-compare -DNDEBUG -g -fwrapv -O3 -Wall -DFFI_BUILDING=1 -DUSE__THREAD -DHAVE_SYNC_SYNCHRONIZE -I/usr/include/ffi -I/usr/include/libffi -I/usr/include/python3.9 -c c/_cffi_backend.c -o build/temp.cygwin-3.4.6-x86_64-cpython-39/c/_cffi_backend.o
  c/_cffi_backend.c:2:10: fatal error: Python.h: No such file or directory
     2 | #include <Python.h>
       |          ^~~~~~~~~~

The above lines mention Python 3.9, but this should be a Python 3.8 build.

This PR links python3 to the correct Python version.

However, problems with ImageMagick started happening a day later, so the Cygwin builds are still failing.

@hugovk
Copy link
Member

hugovk commented Apr 15, 2023

Thanks, let's merge, it gets us a step closer back to green.

@hugovk hugovk merged commit 165ce3f into python-pillow:main Apr 15, 2023
@radarhere radarhere deleted the cygwin_python_version branch April 15, 2023 21:40
@radarhere
Copy link
Member Author

For reasons unknown, the ImageMagick problem has now disappeared, so Cygwin is passing again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants