Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed FIXME comment #7072

Merged
merged 1 commit into from
Apr 6, 2023
Merged

Removed FIXME comment #7072

merged 1 commit into from
Apr 6, 2023

Conversation

radarhere
Copy link
Member

PR #2544 resolved the immediate problem of #2563, but it also added a comment.

Pillow/setup.py

Lines 684 to 687 in 943a7a8

# FIXME (melvyn-sopacua):
# At this point it's possible that best_path is already in
# self.compiler.include_dirs. Should investigate how that is
# possible.

The user was thinking about the logic of the hardcoded paths in setup.py and our use of pkg-config, but it is possible for any given path to be in self.compiler.include_dirs from the very beginning of build_extensions() if the user added it in their install command, like

python3 -m pip install . -v --global-option=build_ext --global-option="-Iinsertedpath"

If the user wants to be eager in adding include directories, I don't think that is a problem. So this PR removes the comment, as it is at least misleading.

@hugovk hugovk merged commit 7e2ac65 into python-pillow:main Apr 6, 2023
@radarhere radarhere deleted the fixme branch April 6, 2023 11:38
@radarhere
Copy link
Member Author

The 3.12 failures are fixed by PR #7059

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants