Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #2544 resolved the immediate problem of #2563, but it also added a comment.
Pillow/setup.py
Lines 684 to 687 in 943a7a8
The user was thinking about the logic of the hardcoded paths in setup.py and our use of
pkg-config
, but it is possible for any given path to be inself.compiler.include_dirs
from the very beginning ofbuild_extensions()
if the user added it in their install command, likeIf the user wants to be eager in adding include directories, I don't think that is a problem. So this PR removes the comment, as it is at least misleading.